OH2-409 | Add lock field to medical ward #1448
Open
+101
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbmalkovsky
reviewed
Nov 12, 2024
dbmalkovsky
reviewed
Nov 12, 2024
|
@SteveGT96 is it possible to add some tests to ensure that lock is effectively updated when we update a 'ward medical'? |
dbmalkovsky
reviewed
Nov 13, 2024
dbmalkovsky
reviewed
Nov 13, 2024
dbmalkovsky
reviewed
Nov 13, 2024
dbmalkovsky
reviewed
Nov 13, 2024
dbmalkovsky
reviewed
Nov 13, 2024
mwithi
reviewed
Nov 14, 2024
mwithi
reviewed
Nov 18, 2024
| @@ -1106,7 +1107,7 @@ void testMgrValidateLotWithCostZero() { | |||
| Movement movement = movementIoOperationRepository.findById(code).orElse(null); | |||
| assertThat(movement).isNotNull(); | |||
| Lot lot = movement.getLot(); | |||
| lot.setCost(new BigDecimal(0.0)); | |||
| lot.setCost(new BigDecimal("0.0")); | |||
There was a problem hiding this comment.
Suggested change
| lot.setCost(new BigDecimal("0.0")); | |
| lot.setCost(BigDecimal.ZERO); |
mwithi
reviewed
Nov 18, 2024
Comment on lines
+61
to
65
| @Version | ||
| @Column(name = "MDSRWRD_LOCK", columnDefinition = "INT(11) NOT NULL DEFAULT 0") | ||
| private int lock; | ||
| @Transient | ||
| private Double qty = 0.0; |
There was a problem hiding this comment.
Suggested change
| @Version | |
| @Column(name = "MDSRWRD_LOCK", columnDefinition = "INT(11) NOT NULL DEFAULT 0") | |
| private int lock; | |
| @Transient | |
| private Double qty = 0.0; | |
| @Version | |
| @Column(name = "MDSRWRD_LOCK", columnDefinition = "INT(11) NOT NULL DEFAULT 0") | |
| private int lock; | |
| @Transient | |
| private Double qty = 0.0; |
dbmalkovsky
reviewed
Nov 18, 2024
| public Lot getLot() { | ||
| return id.getLot(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I would leave a line after the end of the method.
dbmalkovsky
reviewed
Nov 18, 2024
| } | ||
|
|
There was a problem hiding this comment.
I would leave a line after the end of the method.
dbmalkovsky
reviewed
Nov 18, 2024
| public void setWard(Ward ward) { | ||
| this.id.setWard(ward); | ||
| } | ||
|
|
||
| public Medical getMedical() { | ||
| return this.id.getMedical(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I would leave a line after the end of the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OH2-409